Fixing multiproject handling in TransportUpdateDataStreamMappingsAction #130247
Conversation
masseyke
added
>non-issue
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
| ); | ||
| return; | ||
| } | ||
| ProjectId projectId = projectResolver.getProjectId(); |
There was a problem hiding this comment.
This is a pretty small nit, but we usually prefer to resolve the project ID only once, to avoid any confusion whatsoever (and to save a thread context lookup, although that's pretty minor).
There was a problem hiding this comment.
I'm only getting the project ID once, right? Where is the other time?
There was a problem hiding this comment.
Sorry I meant "using the project resolver", as the project resolver is getting the project ID from thread context. I'm referring to projectResolver.getProjectMetadata(state) above.
There was a problem hiding this comment.
Ah, ok. I've changed that now. I never thought of projectId as something I need to be careful about accessing. It's possible there are other places where I'm accessing it frequently.
.../main/java/org/elasticsearch/datastreams/action/TransportUpdateDataStreamMappingsAction.java
Outdated
Show resolved
Hide resolved
nielsbauman
left a comment
nielsbauman
left a comment
There was a problem hiding this comment.
LGTM, thanks for the iterations, Keith!
3 participants
This addresses a couple of bugs in multiproject handling that were raised here: #130042 (comment)